Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mark enterprise runner visibility required #2278

Conversation

gustavlasko
Copy link
Contributor

If the visibility property is not specified on the github_enterprise_actions_runner_group, an error is thrown.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Nope!

Please see our docs on breaking changes to help!

  • Yes
  • No

gustavlasko and others added 2 commits May 31, 2024 11:20
If the `visibility` property is not specified on the
`github_enterprise_actions_runner_group`, an error is thrown.
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our API docs show that this is actually optional, so the required piece is an implementation detail from this repository that could be relaxed. The smart thing to do would be to make that optional in our code.

However, this is a good step in the meantime that corrects the docs error. Thanks!

@kfcampbell kfcampbell merged commit 782d71f into integrations:main Jul 8, 2024
3 checks passed
kireque referenced this pull request in kireque/home-ops Jul 9, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github](https://registry.terraform.io/providers/integrations/github)
([source](https://togithub.com/integrations/terraform-provider-github))
| required_provider | patch | `6.2.2` -> `6.2.3` |

---

### Release Notes

<details>
<summary>integrations/terraform-provider-github (github)</summary>

###
[`v6.2.3`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v6.2.3)

[Compare
Source](https://togithub.com/integrations/terraform-provider-github/compare/v6.2.2...v6.2.3)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### 🛠️ Maintenance

- build(deps): bump the github-actions group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/integrations/terraform-provider-github/pull/2303](https://togithub.com/integrations/terraform-provider-github/pull/2303)

##### 🏷 Other Changes

- fix: Fixing `enterprise_id` import on
`github_enterprise_actions_permissions` by
[@&#8203;ErikElkins](https://togithub.com/ErikElkins) in
[https://github.com/integrations/terraform-provider-github/pull/2274](https://togithub.com/integrations/terraform-provider-github/pull/2274)
- Bump go-github to v62 + fixes by
[@&#8203;EttoreFoti](https://togithub.com/EttoreFoti) in
[https://github.com/integrations/terraform-provider-github/pull/2304](https://togithub.com/integrations/terraform-provider-github/pull/2304)
- docs: mark enterprise runner visibility required by
[@&#8203;gustavlasko](https://togithub.com/gustavlasko) in
[https://github.com/integrations/terraform-provider-github/pull/2278](https://togithub.com/integrations/terraform-provider-github/pull/2278)

#### New Contributors

- [@&#8203;gustavlasko](https://togithub.com/gustavlasko) made their
first contribution in
[https://github.com/integrations/terraform-provider-github/pull/2278](https://togithub.com/integrations/terraform-provider-github/pull/2278)

**Full Changelog**:
integrations/terraform-provider-github@v6.2.2...v6.2.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants